Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump jetty version #968

Merged
merged 6 commits into from
Jan 13, 2020
Merged

Bump jetty version #968

merged 6 commits into from
Jan 13, 2020

Conversation

melowe
Copy link
Contributor

@melowe melowe commented Jan 10, 2020

Fixes #958 . Change jersey tests to use grizzly as we need to migrate… all former javax prefixed group ids to use newer jakarta ones.

@melowe
Fixes #958 . Change jersey tests to use grizzly as we need to migrate…
125667f 
… all former javax prefixed group ids to use newer jakarta ones.
@melowe melowe mentioned this pull request Jan 10, 2020
Closed
SatpalSandhu61
SatpalSandhu61 previously approved these changes Jan 10, 2020
View reviewed changes
@codecov-io
Copy link

codecov-io commented Jan 10, 2020 •
edited
Loading

Codecov Report

Merging #968 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #968   +/-   ##
========================================
  Coverage      99.3%   99.3%           
  Complexity     2160    2160           
========================================
  Files           328     328           
  Lines          5902    5902           
  Branches        355     355           
========================================
  Hits           5861    5861           
  Misses            5       5           
  Partials         36      36
Impacted Files Coverage Δ Complexity Δ
...tessera/nio/unix/UnixSocketFileSystemProvider.java 100% <100%> (ø) 12 <5> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 125667f...40114a1. Read the comment docs.

Krish1979
Krish1979 previously approved these changes Jan 10, 2020
View reviewed changes
@melowe melowe dismissed stale reviews from Krish1979 and SatpalSandhu61 via db28916 January 10, 2020 17:32
chris-j-h
chris-j-h requested changes Jan 13, 2020
View reviewed changes
Copy link
Collaborator

@chris-j-h chris-j-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only one profile can be active at a time. Check the Travis build report for the Acceptance Tests Java 8 job and you'll see that now only the AWS acceptance tests are being run

@melowe melowe merged commit 8cecc43 into master Jan 13, 2020
@Krish1979 Krish1979 added 0.10.3 0.10.3 dependencies Pull requests that update a dependency file labels Feb 3, 2020
@prd-fox prd-fox deleted the upgrade_jetty_version branch February 10, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-j-h chris-j-h chris-j-h approved these changes

@SatpalSandhu61 SatpalSandhu61 SatpalSandhu61 left review comments

@Krish1979 Krish1979 Krish1979 left review comments

@namtruong namtruong Awaiting requested review from namtruong namtruong is a code owner

@nicolae-leonte-go nicolae-leonte-go Awaiting requested review from nicolae-leonte-go

@prd-fox prd-fox Awaiting requested review from prd-fox

Assignees
No one assigned
Labels
0.10.3 0.10.3 dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ThirdParty server hangup problem with 7nodes example
5 participants
@melowe @codecov-io @SatpalSandhu61 @Krish1979 @chris-j-h